[PATCH] D46311: [AArch64] added FP16 vcvth intrinsic support

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 2 06:29:47 PDT 2018


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Thanks, looks good to me now. One more nit inlined, but no need for another review.



================
Comment at: lib/Target/AArch64/AArch64InstrFormats.td:5982
     let Predicates = [HasNEON, HasFullFP16] in {
-    def #NAME#16 : BaseSIMDThreeScalar<U, {S,0b10}, {0b00,opc}, FPR16, asm,
-      []>;
+    def #NAME#16 : BaseSIMDThreeScalar<U, {S,0b10}, {0b00,opc}, FPR16, asm, []>; 
     } // Predicates = [HasNEON, HasFullFP16]
----------------
No changes were made here, so can you keep the old formatting?


Repository:
  rL LLVM

https://reviews.llvm.org/D46311





More information about the llvm-commits mailing list