[PATCH] D44598: [lit] Report line number for failed RUN command

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

Aaannnddd, I didn't hit save in phabricator sorry, so here are those inline comments.



================
Comment at: utils/lit/tests/shtest-run-at-line.py:21
+# CHECK-NEXT: : 'RUN: at line 2' &&  false
+# CHECK-NEXT: : 'RUN: at line 3' &&  true
+
----------------
On Windows, the output I get here is:

Script:
--
echo "RUN: at line 1" > nul &&  true
echo "RUN: at line 2" > nul &&  false
echo "RUN: at line 3" > nul &&  true

And no subsequent trailing stderr


================
Comment at: utils/lit/tests/shtest-run-at-line.py:31
+# CHECK:      Script:
+# CHECK:      : 'RUN: at line 1' &&  : first line continued    to second line
+# CHECK-NEXT: : 'RUN: at line 3' &&  echo 'foo bar'  | FileCheck
----------------
Similar to above, on Windows I get

echo "RUN: at line 1" > nul &&  : first line continued    to second line

Here, as well as no stderr.


https://reviews.llvm.org/D44598