[PATCH] D46273: [InstCombine, ARM] Convert vld1 to llvm load

[Alexandros Lamprineas via Phabricator via llvm-commits]

labrinea added a comment.

The dynamic cast check for the alignment parameter of the intrinsic is necessary. I could bail the optimization if it's not constant and let the backend crash later on. There are plenty of intrinsics where some arguments need to be constant, but IR has no way to enforce that. Clang will guarantee for it. The rest of the suggestions sound sensible. I'll update my patch accordingly.


https://reviews.llvm.org/D46273