[PATCH] D45948: [MIRParser] Allow register class names in the form of integer/scalar

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 2 02:13:40 PDT 2018


thegameg added a comment.

In https://reviews.llvm.org/D45948#1084799, @aheejin wrote:

> There are cases in which `i32` is used to signify a constant type:
>  Example 1 <https://github.com/llvm-mirror/llvm/blob/81352e1cb7abb274ba345342a25aa824a3208c5f/test/CodeGen/X86/GlobalISel/legalize-brcond.mir#L44-L45>
>  Example 2 <https://github.com/llvm-mirror/llvm/blob/81352e1cb7abb274ba345342a25aa824a3208c5f/test/CodeGen/MIR/X86/instructions-debug-location.mir#L85>
>  And there are many more. So changing the category of `i32` to an identifier will cause all these tests to fail.


Right. My question was: would it make sense to *always* lex it as identifier and update `parseTypedImmediateOperand`to also do what we do in `maybeLexIntegerOrScalarType`.


Repository:
  rL LLVM

https://reviews.llvm.org/D45948





More information about the llvm-commits mailing list