[PATCH] D46326: ThinLTO+CFI: short-circuit direct calls to jump table entries

[Dmitry Mikulin via Phabricator via llvm-commits]

dmikulin marked 2 inline comments as done.
dmikulin added a comment.

Yeah, need a test case.

In https://reviews.llvm.org/D46326#1084792, @vlad.tsyrklevich wrote:

> Also, definitions in the merged module are set to have internal linkage which will not work if we plan to call them directly in other modules. We'll need to change their linkage.


Can you give an example? I'm not sure I completely follow...



================
Comment at: llvm/lib/IR/Value.cpp:506
+      continue;
+    U.set(New);
+  }
----------------
efriedma wrote:
> This looks like it doesn't handle the case of a function with a function pointer argument correctly.
I thought getCalledFunction on a CallInst takes care of it... 


https://reviews.llvm.org/D46326