[PATCH] D46259: [CFLGraph][NFC] Simplify/reorder switch in visitConstantExpr

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 1 18:14:23 PDT 2018


xbolva00 added inline comments.


================
Comment at: llvm/trunk/lib/Analysis/CFLGraph.h:548
-        break;
-      }
-      case Instruction::InsertElement: {
----------------
efriedma wrote:
> The logic for selects looks suspicious; operand 0 is the condition.
Yep true. Seems like this is quite an old bug here.

We should use operands 1 and 2 here.

I will post a new patch tomorrow.


Repository:
  rL LLVM

https://reviews.llvm.org/D46259





More information about the llvm-commits mailing list