[PATCH] D45492: [Verifier] Check for TBAA Access Tag presence

[Ivan Kosarev via Phabricator via llvm-commits]

kosarev added inline comments.


================
Comment at: lib/IR/Verifier.cpp:5037-5038
+bool TBAAVerifier::ShouldHaveTBAAAccessTag(Instruction &I) {
+  return isa<LoadInst>(I) || isa<StoreInst>(I) || isa<VAArgInst>(I) ||
+         isa<AtomicRMWInst>(I) || isa<AtomicCmpXchgInst>(I);
+}
----------------
We generate a significant amount of such instructions that are not supposed to be decorated. See for example D41562 and D39138. For my local experiments I was adding marks associated with load and store instructions that give a clue on their origin. If we can have such a mechanism in the mainline to make things like this patch more useful, then that would be great.


Repository:
  rL LLVM

https://reviews.llvm.org/D45492