[PATCH] D45990: GlobalISel/InstructionSelector: Implement GIR_CopyFConstantAsFPImm

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 1 11:08:49 PDT 2018


dsanders added a comment.

In https://reviews.llvm.org/D45990#1084299, @tstellar wrote:

> I actually don't have a test case of this.  I really just need the enum defined so AMDGPUGenGlobalIsel.inc will build.  I can drop the implementation and just add the enum value if you prefer.


Could you send me the comment that's shortly before the GIR_CopyFConstantAsFPImm in AMDGPUGenGlobalIsel.inc? It should look similar to a tablegen pattern and we can probably derive a test case from that. I'm not sure which rule has been imported but I'm hoping it will be something like (set $rd:GPR, $imm:fpimm) in which case the test would be similar to test/CodeGen/AArch64/GlobalISel/select-constant.mir.


Repository:
  rL LLVM

https://reviews.llvm.org/D45990





More information about the llvm-commits mailing list