[PATCH] D46243: Move Schedule class to header file for allowing inheritance

[Eugene Zelenko via Phabricator via llvm-commits]

Eugene.Zelenko added inline comments.


================
Comment at: include/llvm/CodeGen/PostRASchedulerList.h:31
 #include "llvm/CodeGen/ScheduleDAGInstrs.h"
 #include "llvm/CodeGen/ScheduleHazardRecognizer.h"
 #include "llvm/CodeGen/SchedulerRegistry.h"
----------------
Are all these header necessary? You could use forward declarations for pointers/references.

Include What You Use is helpful too.


================
Comment at: include/llvm/CodeGen/PostRASchedulerList.h:60
+};
+char PostRAScheduler::ID = 0;
+
----------------
Please move to source file.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46243