[PATCH] D44560: [DWARF] Rework debug line parsing to use llvm::Error and callbacks

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In https://reviews.llvm.org/D44560#1083788, @jhenderson wrote:

> A separate change could be made to simply jump directly to the desired offset rather than iterating over each table in turn, when a specific offset is specified. This would sort out this problem, and also allow further testing of the unit length field (e.g. to see if it falls within the section boundaries).


Hmm one reason to iterate through the section is to gain confidence that the specified offset is actually the start of a line-table header.  But I guess if we pick up an offset from a compile-unit, we should really assume it points to a reasonable place (maybe not in verify mode, but normally).

There has been a bit of grumbling on the dwarf-discuss list recently about "whiny consumers" and I think it's a valid point; we should be "tolerant in what we receive" or however the old Internet-RFC put it.


Repository:
  rL LLVM

https://reviews.llvm.org/D44560