[PATCH] D46288: Don't redefine a bunch of defines from llvm-config.h in config.h.

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 30 17:18:48 PDT 2018


bogner added inline comments.


================
Comment at: include/llvm/Config/config.h.cmake:296-297
-/* Target triple LLVM will generate code for by default */
-/* Doesn't use `cmakedefine` because it is allowed to be empty. */
-#define LLVM_DEFAULT_TARGET_TRIPLE "${LLVM_DEFAULT_TARGET_TRIPLE}"
-
----------------
The one in llvm-config.h doesn't have this comment and does use cmakedefine. Please make sure we're still doing the right thing when this is empty (that is, build with -DLLVM_DEFAULT_TARGET_TRIPLE="")


https://reviews.llvm.org/D46288





More information about the llvm-commits mailing list