[PATCH] D46242: Support a funclet operand bundle in LowerInvoke

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 30 17:12:04 PDT 2018


aheejin added inline comments.


================
Comment at: lib/Transforms/Utils/LowerInvoke.cpp:51
     if (InvokeInst *II = dyn_cast<InvokeInst>(BB.getTerminator())) {
-      SmallVector<Value *, 16> CallArgs(II->op_begin(), II->op_end() - 3);
+      SmallVector<Value *, 16> CallArgs(II->arg_begin(), II->arg_end());
       // Insert a normal call instruction...
----------------
rnk wrote:
> I think this pass needs to preserve operand bundles. You probably want to call `II->getOperandBundlesAsDefs(Bundles)`, and then remove `"funclet"` bundles.
Then is this pass supposed to remove funclet operand bundles for call instructions as well?


Repository:
  rL LLVM

https://reviews.llvm.org/D46242





More information about the llvm-commits mailing list