[PATCH] D41827: [DEBUG] Initial adaptation of NVPTX target for debug info emission.

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 30 17:00:53 PDT 2018


echristo added a comment.

In https://reviews.llvm.org/D41827#1083441, @echristo wrote:

> In https://reviews.llvm.org/D41827#1083429, @ABataev wrote:
>
> > In https://reviews.llvm.org/D41827#1083428, @echristo wrote:
> >
> > > In https://reviews.llvm.org/D41827#1083427, @ABataev wrote:
> > >
> > > > In https://reviews.llvm.org/D41827#1083412, @echristo wrote:
> > > >
> > > > > FWIW I'm seeing internal correctness issues after this patch has been merged - I think it's related to the section changing part of the patches. I'm investigating.
> > > >
> > > >
> > > > :( Very said. Do have troubles with NVPTX target or some other targets?
> > >
> > >
> > > NVPTX :(
> >
> >
> > Do you have a repro?
>
>
> Not yet. Trying to work one up.


So this diff:

- for (const std::string &S : DwarfFiles)
- getStreamer().EmitRawText(S.data());

+    //    for (const std::string &S : DwarfFiles)
+    //    getStreamer().EmitRawText(DwarfFiles.front().data());

causes the problem to go away.

The problem shows up this way:

There is more than one initializer with name 'file'

during program startup (within google so you won't be able to duplicate this part). which seems a little weird, but I'm guessing that there's something going on in the way that we're outputting the file changes at section switch time with how ptxas is dealing with it.

For now I'm going to go ahead and revert this because it's making it so that cuda compilation isn't working with clang and I'll continue working up a testcase and see if I can't narrow down the problem a little better and get back to you soon.


Repository:
  rL LLVM

https://reviews.llvm.org/D41827





More information about the llvm-commits mailing list