[PATCH] D46076: [PPC64] Replace several endianess checks with abi checks.
Eric Christopher via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 30 14:06:41 PDT 2018
echristo added a comment.
This LGTM FWIW. (Acking to have it pop back up in people's queues).
================
Comment at: ELF/Target.h:157-161
+// Checks for abi version 2 when targeting PPC64.
+bool isPPC64ElfV2();
+
uint64_t getPPC64TocBase();
uint64_t getAArch64Page(uint64_t Expr);
----------------
IMO this is going to get unwieldy after a while (making it part of the base class), but it looks like you're also just following existing practice.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D46076
More information about the llvm-commits
mailing list