[PATCH] D46217: [llvm-objcopy] Add --weaken option

[Paul Semel via Phabricator via llvm-commits]

paulsemel added a comment.

Sure, here is what I've got so far :

Generally speaking, while copying, objcopy turns `common` symbols into `object` symbols. Otherway, it goes the same as it is with other symbol types.

For `--globalize-symbol` option :

- doesn't do anything for weak symbols
- works with undefined local symbols

For `--localize-symbol` option:

- works with all (but undef of course) symbols

So, do you think that I need to change the behavior of those two options to match the `objcopy` behavior ?

Thanks for taking the time to ask Roland McGrath !


Repository:
  rL LLVM

https://reviews.llvm.org/D46217