[PATCH] D46240: [llvm] Removing writeonly and readnone incompatibility.

Brian Homerding via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 30 13:01:39 PDT 2018


homerdin added a comment.

Thanks for the review, I should have provided my intent from the beginning.

I am working to enable functions that only write to memory to be hoisted out of loops and to combined by EarlyCSE, more specifically I am working to mark the math functions that only write to errno as writeonly then have them handled as writeonly functions.

It seems I was mislead by the name readnone, when it is intended as read none and write no visible state.

I will abandon this change and look to see why functions are being marked as both writeonly and readnone with my changes when the function writes.

Any thoughts on how we can enable the changes I am working towards would be appreciated.


https://reviews.llvm.org/D46240





More information about the llvm-commits mailing list