[PATCH] D46274: [Support] Harden JSON against invalid UTF-8.

[Sam McCall via llvm-commits]

Thanks for the comments!
Not validating codepoints was deliberate but in hindsight arbitrary, I'll
fix that. (Both surrogates and high codepoints).

Regarding a separate library: I agree in principle :-) but am concerned
about the potential scope/generality and don't have cycles to design it
right now, even extracting JSON is a bit of a yak-shave...
Here it's in support and exposed as free functions, so if it really is
useful, it *is* available and we can move it later.
That's the best argument I can come up with, open to better ideas :)

On Mon, Apr 30, 2018, 19:51 Ben Hamilton via Phabricator <
reviews at reviews.llvm.org> wrote:

> benhamilton added a comment.
>
> Also, IMHO, this logic should be in a separate UTF-8 library so we can use
> it outside of JSON contexts.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D46274
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180430/df035cbb/attachment.html>