[PATCH] D45552: [NFC][LV][LoopUtil] Move LoopVectorizationLegality to its own file

[Hideki Saito via Phabricator via llvm-commits]

hsaito added a comment.

In https://reviews.llvm.org/D45552#1082961, @rengolin wrote:

> In https://reviews.llvm.org/D45552#1082936, @hsaito wrote:
>
> > For example, in loop fusion scenarios, doing this is not a rocket science.
>
>
> Right, this is still loop transformation, so staying inside Transform still makes sense.
>
> I'm not disagreeing with you on the topics:
>
> 1. It does look like an analysis pass
> 2. Other passes could profit
>
>   However, so far, the other passes are all in the transform directory.
>
>   I agree we need to split "what" can be done from "how we'll do it" and I agree we need to make `LoopUtils` more generic. I was just trying to be clear on why we shouldn't move to `include/Analysis` yet.


There seems like a disconnect. I fully understood the resistance for moving them to Analysis. I thought you are going against making it available from include/llvm/Transform/Vectorize (as opposed to lib/Transforms/Vectorize).
Pushing them to include/llvm/Transform/Vectorize is already a big improvement and I'm quite happy about that.


Repository:
  rL LLVM

https://reviews.llvm.org/D45552