[PATCH] D45878: [DEBUG INFO] Fixing cases where debug info (-g) causes changes in the program.

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 30 07:50:27 PDT 2018


bjope added inline comments.


================
Comment at: lib/Target/SystemZ/SystemZElimCompare.cpp:195
+  DbgValues.clear();
+  if (!MI.getOperand(0).isReg())
+    return;
----------------
Shouldn't we iterate over all MI defs (both explicit and implicit)?
If there is a reason for limiting this to check some operands, then perhaps this check should be on the caller side (and then the register could be passed as an argument).


https://reviews.llvm.org/D45878





More information about the llvm-commits mailing list