[PATCH] D46181: [X86][CET] Shadow stack fix for setjmp/longjmp

[H.J Lu via Phabricator via llvm-commits]

hjl.tools added inline comments.


================
Comment at: llvm/test/CodeGen/X86/shadow-stack.ll:47
+; X86_64-NEXT:    shlq %rcx
+; X86_64-NEXT:    movabsq $128, %rdx
+; X86_64-NEXT:  .LBB0_4: # %entry
----------------
Why movabsq $128?  incssp takes last 8 bits.  "movl $255" works.


================
Comment at: llvm/test/CodeGen/X86/shadow-stack.ll:76
+; X86-NEXT:    shll %ecx
+; X86-NEXT:    movl $128, %edx
+; X86-NEXT:  .LBB0_4: # %entry
----------------
Why movl $128?  incssp takes last 8 bits.  "movl $255" works.


https://reviews.llvm.org/D46181