[PATCH] D45756: [XRay][profiler] Part 1: XRay Allocator and Array Implementations

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added a comment.

In https://reviews.llvm.org/D45756#1082146, @kpw wrote:

> This looks better now, although there were a few issues that slipped through the tests and I wonder if there are others lurking.
>
> If we're going to maintain this cache-line aware storage structure, do you have a plan to measure the performance impact on the GWP implementation versus using a more simple container like sanitizer/vector.h?
>  This seems important to me because certain kinds of mistakes might still leave the interface operating correctly, but screw up the performance details.


Yes, I have that on the list of things to do (add microbenchmarks to the test-suite).

I had some initial measurements on the cost of an early implementation, which basically show that the cost of reaching for additional memory and copying elements dominate. Those are important things to measure and make sure we can track going forward. It's also the whole point of us going through this route, to mitigate the problems we've encountered in the early prototype of this. :)


https://reviews.llvm.org/D45756