[PATCH] D46214: Avoid reading past end of archive looking for long file name

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 28 10:56:44 PDT 2018


inglorion added a comment.

A test case for this would be an archive with a long file name at the end of the string table. It may have to be a specific size to tickle the problem I'm trying to fix here, to prevent MemoryBuffer or the OS from padding the archive with 0 bytes, which would avoid the problem.

Unfortunately, I have to catch a plane and I'll be gone for a week. If anyone wants to commandeer this and land it, please go ahead.


https://reviews.llvm.org/D46214





More information about the llvm-commits mailing list