[PATCH] D45862: [InstCombine] Remove decanonicalizing transforms of selects

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D45862#1081927, @mkazantsev wrote:

> In https://reviews.llvm.org/D45862#1081919, @spatel wrote:
>
> > In https://reviews.llvm.org/D45862#1081907, @mkazantsev wrote:
> >
> > > Current strategy of saving one instruction by adding this bit magic produces horrible code on the tests I've added.
> >
> >
> > Please commit these tests, so we can see the current output and compare any differences between this patch and the other patch.
>
>
> Here it is. Please compare the cases when we compare against zero with cases when we compare against any other value.
>  https://reviews.llvm.org/rL331100


Thanks! I updated https://reviews.llvm.org/D46086. Unless I've missed it, the diffs for the 3-way-compare tests are identical?


https://reviews.llvm.org/D45862