[PATCH] D45862: [InstCombine] Remove decanonicalizing transforms of selects

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 27 21:43:46 PDT 2018


mkazantsev added a comment.

In https://reviews.llvm.org/D45862#1081919, @spatel wrote:

> In https://reviews.llvm.org/D45862#1081907, @mkazantsev wrote:
>
> > Current strategy of saving one instruction by adding this bit magic produces horrible code on the tests I've added.
>
>
> Please commit these tests, so we can see the current output and compare any differences between this patch and the other patch.


Here it is. Please compare the cases when we compare against zero with cases when we compare against any other value.


https://reviews.llvm.org/D45862





More information about the llvm-commits mailing list