[PATCH] D46208: Don't create a temporary DenseMap for each input .eh_frame

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 27 13:12:30 PDT 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/SyntheticSections.h:89
 private:
+  llvm::DenseMap<size_t, CieRecord *> OffsetToCie;
   uint64_t Size = 0;
----------------
Please add a comment to explain that this doesn't have to be a member from the point of view of correctness, but we do this to reuse allocated buffer.


https://reviews.llvm.org/D46208





More information about the llvm-commits mailing list