[PATCH] D46177: [llvm-objcopy] Add --globalize-symbol option

Paul Semel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 27 09:25:53 PDT 2018


paulsemel added inline comments.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:139
+    -> decltype(std::end(Container), true) {
+  return std::end(Container) !=
+         std::find(std::begin(Container), std::end(Container), X);
----------------
alexshap wrote:
> well, actually, even better - let's delete this and make use of
>  ./STLExtras.h:967  bool is_contained(R &&Range, const E &Element)
Oups.. I'm sorry, I completely missed this function..
Changing to this one ! Thanks !


Repository:
  rL LLVM

https://reviews.llvm.org/D46177





More information about the llvm-commits mailing list