[PATCH] D46169: Split merge sections early

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 27 08:48:16 PDT 2018


ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: ELF/InputSection.h:226-227
 
   // Mark the piece at a given offset live. Used by GC.
-  void markLiveAt(uint64_t Offset) {
-    if (this->Flags & llvm::ELF::SHF_ALLOC)
-      LiveOffsets.insert(Offset);
-  }
+  void markLiveAt(uint64_t Offset);
 
----------------
I'd remove this function and inline it.


https://reviews.llvm.org/D46169





More information about the llvm-commits mailing list