[PATCH] D46178: [SCEV] Reduce the number of invocation to non trivial getExact function

Javed Absar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 27 02:30:58 PDT 2018


javed.absar accepted this revision.
javed.absar added a comment.
This revision is now accepted and ready to land.

Please rephrase this part of  commit message as it is hard to read/understand - "And even if statistics is disable and code
related to it will be eliminated the invocation to getExact itself will not be eliminated because it may have side-effects like creation of new SCEVs".

May be something like this - "Even if statistics is disabled,  the code related to it will be eliminated the invocation to getExact itself will not be eliminated
because it may have side-effects like creation of new SCEVs". - if you agree with it


https://reviews.llvm.org/D46178





More information about the llvm-commits mailing list