[PATCH] D46177: [llvm-objcopy] Add --globalize-symbol option

Paul Semel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 27 02:22:23 PDT 2018


paulsemel updated this revision to Diff 144301.
paulsemel marked 2 inline comments as done.
paulsemel added a comment.

Applied James' suggestions :

- Refactor the std::find code into a `contains` function
- Removed useless section in test
- Removed useless check `if (!Config.SymbolsToXX.empty())`


Repository:
  rL LLVM

https://reviews.llvm.org/D46177

Files:
  test/tools/llvm-objcopy/globalize.test
  tools/llvm-objcopy/Opts.td
  tools/llvm-objcopy/llvm-objcopy.cpp
  tools/llvm-objcopy/llvm-objcopy.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46177.144301.patch
Type: text/x-patch
Size: 4691 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180427/c56655ed/attachment.bin>


More information about the llvm-commits mailing list