[PATCH] D46178: [SCEV] Reduce the number of invocation to non trivial getExact function

Javed Absar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 27 01:25:12 PDT 2018


javed.absar added a comment.

AFAIU the correctness check would now get  gated on STATS colelction and that may not be right. I would recommend separating the two.



================
Comment at: lib/Analysis/ScalarEvolution.cpp:6506
+#if LLVM_ENABLE_STATS
+  auto *BEExact = Result.getExact(L, this);
+  if (BEExact != getCouldNotCompute()) {
----------------
Please s/auto/"const SCEV *" to be consistent with other such instances in SCEV.



https://reviews.llvm.org/D46178





More information about the llvm-commits mailing list