[PATCH] D46147: [NVPTX] Added a feature to use short pointers for const/local/shared AS.

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 26 15:42:12 PDT 2018


tra marked an inline comment as done.
tra added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelDAGToDAG.cpp:738
 
+  bool UseShortPointer = Subtarget->useShortPointers();
   if (DstAddrSpace == ADDRESS_SPACE_GENERIC) {
----------------
jlebar wrote:
> s/ShortPointer /ShortPointers /?
> 
> Same below.
In this case we're dealing with just one pointer, while the subtarget can use any number of them. :-)
Oh, well, plural it is.


https://reviews.llvm.org/D46147





More information about the llvm-commits mailing list