[PATCH] D46142: [MCA] [NFC] Remove unused Index formal from ResourceManager::issueInstruction

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 26 13:15:35 PDT 2018


mattd created this revision.
mattd added a reviewer: andreadb.
Herald added subscribers: gbedwell, javed.absar.

The instruction index was never referenced in the body.  Just a minor cleanup.


https://reviews.llvm.org/D46142

Files:
  tools/llvm-mca/Scheduler.cpp
  tools/llvm-mca/Scheduler.h


Index: tools/llvm-mca/Scheduler.h
===================================================================
--- tools/llvm-mca/Scheduler.h
+++ tools/llvm-mca/Scheduler.h
@@ -362,7 +362,7 @@
   bool canBeIssued(const InstrDesc &Desc) const;
 
   void issueInstruction(
-      unsigned Index, const InstrDesc &Desc,
+      const InstrDesc &Desc,
       llvm::SmallVectorImpl<std::pair<ResourceRef, double>> &Pipes);
 
   void cycleEvent(llvm::SmallVectorImpl<ResourceRef> &ResourcesFreed);
Index: tools/llvm-mca/Scheduler.cpp
===================================================================
--- tools/llvm-mca/Scheduler.cpp
+++ tools/llvm-mca/Scheduler.cpp
@@ -179,7 +179,7 @@
 }
 
 void ResourceManager::issueInstruction(
-    unsigned Index, const InstrDesc &Desc,
+    const InstrDesc &Desc,
     SmallVectorImpl<std::pair<ResourceRef, double>> &Pipes) {
   for (const std::pair<uint64_t, ResourceUsage> &R : Desc.Resources) {
     const CycleSegment &CS = R.second.CS;
@@ -350,7 +350,7 @@
 
   // Issue the instruction and collect all the consumed resources
   // into a vector. That vector is then used to notify the listener.
-  Resources->issueInstruction(InstrIndex, D, UsedResources);
+  Resources->issueInstruction(D, UsedResources);
 
   // Notify the instruction that it started executing.
   // This updates the internal state of each write.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46142.144181.patch
Type: text/x-patch
Size: 1350 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180426/d8f9ab53/attachment.bin>


More information about the llvm-commits mailing list