[PATCH] D45845: ELFObjectWriter: Allow one unique symver per symbol

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/MC/ELFObjectWriter.cpp:423
 
+    if (Renames.count(&Symbol) && Renames[&Symbol] != Alias)
+      report_fatal_error(llvm::Twine("Multiple symbol versions defined for ") +
----------------
Nit: I think line 423-427 can be written with one insert:
```if (Renames.insert(std::make_pair(&Symbol, Alias)).first->second != Alias) report_fatal_error(...);```
Maybe a little too terse though.


Repository:
  rL LLVM

https://reviews.llvm.org/D45845