[PATCH] D44184: Write DWARF data into WASM object file
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 26 10:25:13 PDT 2018
sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.
LGTM. Lets get this landed!
================
Comment at: lib/Object/WasmObjectFile.cpp:1012
+ case wasm::WASM_SYMBOL_TYPE_SECTION:
+ return 0; // TODO(yury): section offset from top of the object file?
}
----------------
You can remove this TODO. My understanding is that sections symbols always have value 0. At least on ELF they seem to
Repository:
rL LLVM
https://reviews.llvm.org/D44184
More information about the llvm-commits
mailing list