[PATCH] D45930: [Support] Upstream anonymization and manipulating of BCSymbolMaps

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 26 09:26:50 PDT 2018


JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: llvm/include/llvm/Support/Anonymization.h:10
+//
+// This file provides helper classes to perform string anonymization.
+//
----------------
zturner wrote:
> It's not entirely clear what "anonymization" means.  Can you improve this comment here?
> 
> Also, the summary said it's needed for dsymutil.  Does it need to be in Support?
I hope it will become more clean once I have a diff for the module pass. The latter is also the reason this lives in support, we need it there as well as in dsymutil. 


https://reviews.llvm.org/D45930





More information about the llvm-commits mailing list