[PATCH] D45020: [mips] Accept 32-bit offsets for lb and lbu commands

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 25 23:06:57 PDT 2018


atanasyan updated this revision to Diff 144065.
atanasyan edited the summary of this revision.
atanasyan added a comment.

I created an alternative patch https://reviews.llvm.org/D46105 which replaces `mem_simm16` by `mem` and performs range checking in the `expandLoadInst` routine. But there is a problem with that patch - in the `expandLoadInst` routine we do not know position of invalid operand, so an error message points to the beginning of the incorrect instructions. This patch attempts to use new `mem_simmptr` operand for `lb` and `lbu` instructions and performs range checking in a uniform way with other instructions which use `ParserMatchClass`.


Repository:
  rL LLVM

https://reviews.llvm.org/D45020

Files:
  lib/Target/Mips/AsmParser/MipsAsmParser.cpp
  lib/Target/Mips/MipsInstrInfo.td
  test/MC/Mips/micromips/invalid.s
  test/MC/Mips/micromips32r6/invalid.s
  test/MC/Mips/mips-expansions.s
  test/MC/Mips/mips32r5/invalid.s
  test/MC/Mips/mips32r6/invalid.s
  test/MC/Mips/mips64r5/invalid.s
  test/MC/Mips/mips64r6/invalid.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45020.144065.patch
Type: text/x-patch
Size: 14530 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180426/b79d6877/attachment.bin>


More information about the llvm-commits mailing list