[PATCH] D44184: Write DWARF data into WASM object file

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: include/llvm/Object/RelocVisitor.h:339
+        HasError = false;
+        return 0;
+      }
----------------
Presumably we should be returning something useful here?

Looks like COFF and Mach-O just "return Value" and don't see "HasError" in the success case.


================
Comment at: lib/ObjectYAML/WasmYAML.cpp:408
+  } else if (Info.Kind == wasm::WASM_SYMBOL_TYPE_SECTION) {
+    IO.mapRequired("SectionIndex", Info.SectionIndex);
   } else {
----------------
I would drop the suffix "Index" since we don't use it above in Function, or Global


Repository:
  rL LLVM

https://reviews.llvm.org/D44184