[PATCH] D46029: [llvm-objcopy] Implement --redefine-sym option

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: test/tools/llvm-objcopy/redefine-symbol.test:5
+# RUN: not llvm-objcopy --redefine-sym barbar %t %t2 2>&1 | FileCheck %s --check-prefix=ERROR-MESSAGE
+
+!ELF
----------------
jhenderson wrote:
> Could we add empty symbol names as a test case here as well, please. Also, multiple instances of the switch in the same command-line. Extra credit for a test-case that uses multiple instances of the same switch and renames the same symbol multiple times.
binutils' objcopy does the following:
objcopy --redefine-sym _Z3barv=aaa1 --redefine-sym _Z3barv=aaa2 a.o b.o
objcopy: --redefine-sym: Multiple redefinition of symbol "_Z3barv"


Repository:
  rL LLVM

https://reviews.llvm.org/D46029