[PATCH] D45864: [RISCV] Support .option rvc and norvc

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 25 08:12:04 PDT 2018


asb added a comment.

Thanks Kito. Could you please add some tests for the new warning/failure cases introduced by this patch? e.g. .option with unrecognised identifier etc.



================
Comment at: lib/Target/RISCV/MCTargetDesc/RISCVMCTargetDesc.cpp:98-99
         *T, createRISCVObjectTargetStreamer);
+
+    // Register the asm target streamer.
+    TargetRegistry::RegisterAsmTargetStreamer(*T, createRISCVAsmTargetStreamer);
----------------
Unnecessary comment - the function call is pretty self-descriptive.


https://reviews.llvm.org/D45864





More information about the llvm-commits mailing list