[PATCH] D46032: [MIR] Add support for debug metadata for fixed stack objects

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 25 04:22:07 PDT 2018


thegameg added inline comments.


================
Comment at: test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll:36
 ; CHECK-NEXT:       stack-id: 0, callee-saved-register: '', callee-saved-restored: true,
-; CHECK-NEXT: di-variable: '', di-expression: '', di-location: '' }
+; CHECK-NEXT: debug-info-variable: '', debug-info-expression: '', debug-info-location: '' }
 ; CHECK-NEXT:   - { id: 1, name: ptr2, type: default, offset: 0, size: 8, alignment: 1,
----------------
JDevlieghere wrote:
> In the MappingTraits you say that it shouldn't print if it's empty, which makes sense, but then it's still being printed here?
`yaml::Output` has a `WriteDefaultValues` flag which ignores default values when printing them. Passing `-simplify-mir` to `llc` will skip printing default values.


https://reviews.llvm.org/D46032





More information about the llvm-commits mailing list