[PATCH] D46032: [MIR] Add support for debug metadata for fixed stack objects

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: include/llvm/CodeGen/MachineFunction.h:352
     const DIExpression *Expr;
-    unsigned Slot;
+    int Slot;
     const DILocation *Loc;
----------------
thegameg wrote:
> plotfi wrote:
> > Why the change in type here?
> Fixed stack objects have negative FrameIndex values.
Might be worth adding a comment saying exactly that?


================
Comment at: test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll:36
 ; CHECK-NEXT:       stack-id: 0, callee-saved-register: '', callee-saved-restored: true,
-; CHECK-NEXT: di-variable: '', di-expression: '', di-location: '' }
+; CHECK-NEXT: debug-info-variable: '', debug-info-expression: '', debug-info-location: '' }
 ; CHECK-NEXT:   - { id: 1, name: ptr2, type: default, offset: 0, size: 8, alignment: 1,
----------------
In the MappingTraits you say that it shouldn't print if it's empty, which makes sense, but then it's still being printed here?


https://reviews.llvm.org/D46032