[PATCH] D45768: [mips] Implement GetWriteFlag() for mips

[Simon Dardis via Phabricator via llvm-commits]

sdardis requested changes to this revision.
sdardis added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:1739
   return err & PF_WRITE ? WRITE : READ;
+#elif defined(__mips64)
+  long *exception_source;
----------------
This should be:

``` __mips__ 
``` 
not __mips64 as asan can be built for MIPS32.


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:1744
+
+  exception_source = (long *)ucontext->uc_mcontext.pc;
+  faulty_instruction = (uint32_t)(*exception_source);
----------------
This should be (uint32_t *) not (long *).


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:1747
+
+  op_code = (faulty_instruction >> 26) & 0x3f;
+
----------------
FIXME: Add support for FPU, microMIPS, DSP, MSA memory instructions.


https://reviews.llvm.org/D45768