[llvm] r330699 - [NFC] Remove recently added SE verification because it may be false-positive

[Chandler Carruth via llvm-commits]

On Tue, Apr 24, 2018 at 2:14 AM Max Kazantsev via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: mkazantsev
> Date: Tue Apr 24 02:11:01 2018
> New Revision: 330699
>
> URL: http://llvm.org/viewvc/llvm-project?rev=330699&view=rev
> Log:
> [NFC] Remove recently added SE verification because it may be
> false-positive
>

Just as an FYI -- I wouldn't tag commits lik ethis as "NFC". They have a
clear functionality change: LLVM stops crashing due to false-positive
failures of this. ;]

-Chandler


>
> Modified:
>     llvm/trunk/lib/Transforms/Utils/LoopRotationUtils.cpp
>     llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp
>
> Modified: llvm/trunk/lib/Transforms/Utils/LoopRotationUtils.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LoopRotationUtils.cpp?rev=330699&r1=330698&r2=330699&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Utils/LoopRotationUtils.cpp (original)
> +++ llvm/trunk/lib/Transforms/Utils/LoopRotationUtils.cpp Tue Apr 24
> 02:11:01 2018
> @@ -479,12 +479,6 @@ bool LoopRotate::rotateLoop(Loop *L, boo
>
>    DEBUG(dbgs() << "LoopRotation: into "; L->dump());
>
> -#ifndef NDEBUG
> -  // Make sure that after all our transforms SE is correct.
> -  if (SE)
> -    SE->verify();
> -#endif
> -
>    ++NumRotated;
>    return true;
>  }
>
> Modified: llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp?rev=330699&r1=330698&r2=330699&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp (original)
> +++ llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp Tue Apr 24 02:11:01
> 2018
> @@ -674,12 +674,6 @@ ReprocessLoop:
>    if (Changed && SE)
>      SE->forgetTopmostLoop(L);
>
> -#ifndef NDEBUG
> -  // Make sure that after all our transforms SE is correct.
> -  if (SE)
> -    SE->verify();
> -#endif
> -
>    return Changed;
>  }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180424/b3cde187/attachment.html>