[PATCH] D45862: [InstCombine] Relax restriction in foldSelectInstWithICmp for sake of smaller code size

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

In https://reviews.llvm.org/D45862#1075265, @spatel wrote:

> Can you provide an IR -> asm example for one/some of the problem cases that led you to this (or preferably, file bug reports for them)? If we can fix the cases that we know would regress with a reversal of this IR canonicalization, then we should push ahead with that effort and fix instcombine. We can't guarantee that there won't be regressions, but we should be able to fix problems as they are reported.


Sure, please take a look at https://bugs.llvm.org/show_bug.cgi?id=37147
You can also use tests from https://reviews.llvm.org/D45854 https://reviews.llvm.org/D45855 https://reviews.llvm.org/D45856 https://reviews.llvm.org/D45863 for reference: this is the IR we expect InstCombine to produce.


https://reviews.llvm.org/D45862