[PATCH] D42759: [CGP] Split large data structres to sink more GEPs

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.
Herald added a reviewer: javed.absar.

This is looking good.  Just a few more small comments.



================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:278
+    /// Map serial numbers to Large offset GEPs.
+    DenseMap<GetElementPtrInst *, int> LargeOffsetGEPID;
+
----------------
Probably these maps should also use AssertingVH.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:3781
+        if (isa<Argument>(Base) || isa<GlobalValue>(Base) ||
+            (BaseI && !isa<CastInst>(BaseI) && !isa<BinaryOperator>(BaseI) &&
+             !isa<GetElementPtrInst>(BaseI))) {
----------------
I'm pretty sure it's impossible for `BaseI` to be a `BinaryOperator`, given it's a pointer.


Repository:
  rL LLVM

https://reviews.llvm.org/D42759