[PATCH] D45882: AMDGPU/GlobalISel: Implement select() for @llvm.amdgcn.exp

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:155
+         unsigned VM, bool Compr, unsigned Enabled, bool Done) {
+  DebugLoc DL = Insert->getDebugLoc();
+  MachineBasicBlock &BB = *Insert->getParent();
----------------
I think these are supposed to be const references now


================
Comment at: lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:174
+  MachineRegisterInfo &MRI = MF->getRegInfo();
+  DebugLoc DL = I.getDebugLoc();
+
----------------
Ditto


================
Comment at: test/CodeGen/AMDGPU/GlobalISel/inst-select-amdgcn.exp.mir:3-4
+
+--- |
+  define void @exp0() { ret void }
+...
----------------
You should be able to drop the IR section


Repository:
  rL LLVM

https://reviews.llvm.org/D45882