[PATCH] D45983: [X86] movdiri and movdir64b instructions

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 23 14:11:51 PDT 2018


craig.topper added inline comments.


================
Comment at: lib/Support/Host.cpp:1268
+  // Direct move instruction support.
+  Features["movdiri"]         = HasLeaf7 && ((ECX >> 27) & 1);
+  Features["movdir64b"]       = HasLeaf7 && ((ECX >> 28) & 1);
----------------
Drop the comment and put these bit checks with the other Leaf7 ECX bit checks above.


================
Comment at: lib/Target/X86/X86InstrMovdir.td:1
+//===-- X86InstrMovdir.td - Direct Move Instructions ------*- tablegen -*-===//
+//
----------------
I don't know that a new file is warranted for so few instructions. Just add them to X86InstrInfo.td


Repository:
  rL LLVM

https://reviews.llvm.org/D45983





More information about the llvm-commits mailing list