[PATCH] D45537: [CodeGenPrepare] Move Extension Instructions Through Logical And Shift Instructions

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi,

High level comment to help me dive into your changes.
See inlined.

Cheers,
Q



================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:3254
   /// \p PromotedInsts maps the instructions to their type before promotion.
-  static bool canGetThrough(const Instruction *Inst, Type *ConsideredExtType,
+  static bool canGetThrough(const Instruction *Inst, const Instruction *ExtInst,
+                            Type *ConsideredExtType, const TargetLowering &TLI,
----------------
Could you add comments explaining what the new parameters are and their use?


================
Comment at: test/Transforms/CodeGenPrepare/X86/ext-logicop.ll:1
+; RUN: opt < %s -codegenprepare -S -mtriple=x86_64-unknown-unknown    | FileCheck %s
+
----------------
Could you run opt instnamer on the input file first?
(To get rid of the implicit variable (%[0-9]+)


Repository:
  rL LLVM

https://reviews.llvm.org/D45537