[llvm] r330639 - Fix a broken typedef; NFCI

George Burgess IV via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 23 13:03:00 PDT 2018


Author: gbiv
Date: Mon Apr 23 13:03:00 2018
New Revision: 330639

URL: http://llvm.org/viewvc/llvm-project?rev=330639&view=rev
Log:
Fix a broken typedef; NFCI

Richard Smith noted that `typedef typename iplist::iplist_impl_type
iplist_impl_type` is incorrect, per
http://eel.is/c++draft/basic.scope#class-2

It seems that neither clang nor gcc get too angry about this, but a
newer version of msvc does.

Thanks to jcmac on IRC for pointing this out!

Modified:
    llvm/trunk/include/llvm/ADT/ilist.h

Modified: llvm/trunk/include/llvm/ADT/ilist.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/ilist.h?rev=330639&r1=330638&r2=330639&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ADT/ilist.h (original)
+++ llvm/trunk/include/llvm/ADT/ilist.h Mon Apr 23 13:03:00 2018
@@ -178,9 +178,6 @@ template <class IntrusiveListT, class Tr
 class iplist_impl : public TraitsT, IntrusiveListT {
   typedef IntrusiveListT base_list_type;
 
-protected:
-  typedef iplist_impl iplist_impl_type;
-
 public:
   typedef typename base_list_type::pointer pointer;
   typedef typename base_list_type::const_pointer const_pointer;
@@ -402,7 +399,7 @@ public:
 template <class T, class... Options>
 class iplist
     : public iplist_impl<simple_ilist<T, Options...>, ilist_traits<T>> {
-  typedef typename iplist::iplist_impl_type iplist_impl_type;
+  using iplist_impl_type = typename iplist::iplist_impl;
 
 public:
   iplist() = default;




More information about the llvm-commits mailing list