[PATCH] D45970: [LoopInterchange] Do not change LI for BBs in child loops.

Mon Apr 23 12:23:27 PDT 2018

fhahn added a comment.

In https://reviews.llvm.org/D45970#1075792, @efriedma wrote:

> Needs testcase.

tests/Transform/LoopInterchange/phi-ordering.ll has a loop nest with 3 levels deep that gets interchanged twice and exposes the problem. With https://reviews.llvm.org/D45971, -verify-loop-info on the test case should fail (and I think there is another test case that also fails with https://reviews.llvm.org/D45971). I am happy to add a separate test case, in case you think that's valuable.

>> LoopInterchange did that wrong and this additional assertion catches that. The fix for LoopInterchange is at https://reviews.llvm.org/D45970
> 
> Did you mean to post this on a different patch?

Yes, I meant to post this on https://reviews.llvm.org/D45971...

Repository:
  rL LLVM

https://reviews.llvm.org/D45970